cucapra / pollen

generating hardware accelerators for pangenomic graph queries
MIT License
27 stars 1 forks source link

Work on Docker image #11

Closed anshumanmohan closed 1 year ago

anshumanmohan commented 1 year ago

This PR introduces Docker support. The main deliverable is the Dockerfile we will use to build the image, which we will then push to GHCR. Let's merge this branch in once we are happy with the Docker image that the Dockerfile creates.

I have already built and pushed an image based on the current Dockerfile; this is temporarily hosted on Dockerhub. Pull and run it with

docker pull anshumanmohan/pollen
docker run -it anshumanmohan/pollen /bin/bash

To make changes to the image, navigate so that this Dockerfile in your working directory. Then

docker build -t username/pollen .
docker run -it username/pollen /bin/bash

Note the period at the end of the first command.

anshumanmohan commented 1 year ago

I imagine the improvements we'll want will include:

  1. Getting all the flavors of make to work correctly.
  2. Doing some hacking to get resource estimation (via fud's remote facility) working.

A (short) list of things that do work at present, and we should try not to break as we make progress:

  1. fud works from the command line.
  2. odgi works from the command line.
  3. import odgi works from inside a Python environment.
susan-garry commented 1 year ago

This is a great idea! The current problem that I am running into is that the calyx.py_ast module is not available from our docker image, even though it is available in the base image (the calyx docker image). At the moment, I don't know what is causing this

susan-garry commented 1 year ago

Okay, I fixed the import issue (odgi was only visible from the root directory; calyx.py_ast seems not to have had any issues), and all of the tests now pass when we run make test inside the docker.

The only thing left to do, I believe, is figure out how to get resource estimation working (maybe try sshing into the server that the docker is running on?)

anshumanmohan commented 1 year ago

I've updated the imagine on Dockerhub so it reflects the changes above.

anshumanmohan commented 1 year ago

Quick update, I've gotten through the GHCR crud and now we have a nice Packages section on the repo's landing page.