cucapra / pollen

generating hardware accelerators for pangenomic graph queries
MIT License
24 stars 1 forks source link

Use a new Turnt feature to simplify validate tests #112

Closed sampsyo closed 12 months ago

sampsyo commented 12 months ago

(A successor to #111. Until that's merged, this PR will seem to duplicate those changes.)

We had a problem with the tests for slow_odgi validate that made things sorta inconvenient in the Turnt config. The problem was that we needed to produce invalid .gfa files, and odgi required them to have that suffix, but this would in turn cause Turnt to pick them up as extra tests.

I added a new feature to Turnt in https://github.com/cucapra/turnt/pull/27 that just lets us quarantine those invalid .gfas in a separate directory so we won't get confused anymore. This makes the validate tests more like other tests we already have and avoids the need for moving around temporary files.

sampsyo commented 12 months ago

Excellent!