search

cucapra / pollen

generating hardware accelerators for pangenomic graph queries
MIT License
24 stars 1 forks source link

Small `slow-odgi` testing fixes, hopefully to fix #119 #123

Closed sampsyo closed 11 months ago

sampsyo commented 11 months ago

This fixes a couple of issues in the slow-odgi testing setup pointed out in #119. With this, on my machine, cleaning everything and running it from scratch produces only two failures:

not ok 17 - test/note5.gfa flip_test # differing: test/note5.flip
not ok 4 - test/handmade/flip4.gfa flip_test # differing: test/handmade/flip4.flip

If this seems to work good for one of @susan-garry & @anshumanmohan, these should at least get us closer to everything working. It would be great to know from @susan-garry whether there are any more failures remaining after this (and if so, which).

anshumanmohan commented 11 months ago

Can confirm, same on my end!

susan-garry commented 11 months ago

Same for me! I know that note5.flip is expected to fail; should we expect handmade/flip4.flip to fail as well?

anshumanmohan commented 11 months ago

Yes, this is a known point of divergence. The slow-odgi README documents it and provides a pointer, if you're curious!