Closed anshumanmohan closed 1 year ago
Just took a look, and I don't really see an opportunity. There may be lifting within the pollen_data_gen
module, but I don't think anything else from here needs to be lifted all the way out of this module and into the mygfa
module.
The precomputation done inside
depth
was written beforemygfa
(orslow_odgi
) was a thing, but I suspect there is some duplication going on. Even if not, certainly some of that computation can be lifted intomygfa/precompute
so that other commands can use it. Case in point, this lifting should happen before starting work on #96 , so that the expandedsimple
can use the computation that currently lives indepth
.pollen_data_gen depth
andmygfa/preprocess
. Cut down on any.pollen_data_gen depth
tomygfa/preprocess
.