cucumber-attic / cucumber-engine

Shared go binary that can be used by all language implementations
MIT License
6 stars 0 forks source link

switch to protocol buffers #3

Closed charlierudolph closed 5 years ago

charlierudolph commented 6 years ago

If sticking with json need to add a schema.

Switching to protocol buffers could another option.

Pros:

Cons:

charlierudolph commented 6 years ago

Some initial work for protocol buffers is on the branch cr-protobuf. This will require defining proto messages for the gherkin pickle and all the events. Will probably want to move the proto definitions into their own repo.

aslakhellesoy commented 6 years ago

Excited to see protobuf taking shape! I’d prefer to go down the protobuf route for now. Code generation for protobuf is way better than for JSONSchema, so that will save us some coding - there are losts of message types.

If a language doesn’t have protobuf we can add JSON back. I think people will want protobuf in a language before they want Cucumber, so I think the chances are slim we’ll have to. Even Nim has protobuf!

charlierudolph commented 5 years ago

Done in 0c27ca853995dccaa21259dbe3593b965ccab702