search

cucumber-attic / cucumber-html

Cross platform HTML formatter for all implementations of Cucumber
Other
40 stars 49 forks source link

Problem with formatter.js in tag 0.2.3 #26

Closed PhilBaker13 closed 11 years ago

PhilBaker13 commented 11 years ago

It seems 0.2.3 is not pulling in the latest version of formatter.js. Can we have a new 0.2.4 build please?

Currently if you use 0.2.3, there is a Javascript error and the Cucumber report contains only the first line

features/login.feature Feature: Log in As a customer of NIB I want to be able to log into NIB So that I can view my account

... no further output

If I update to the latest formatter.js which includes the .before & .after block, that fixes this problem and the report is generated. It comes out with all the pretty colouring and highlights any errors where they occur in the script - really useful

I'm running cucumber-jvm from Maven with dependency

<dependency>
    <groupId>info.cukes</groupId>
    <artifactId>cucumber-html</artifactId>
    <version>0.2.3</version>
 </dependency>
paoloambrosio commented 11 years ago

On Mon, Aug 26, 2013 at 10:06 PM, PhilBaker13 notifications@github.com wrote:

It seems 0.2.3 is not pulling in the correct version of formatter.js. Can we have a new 0.2.4 build that is correct?

Tried diffing formatter.js in the maven repository with the latest sources and there is no difference, and nothing has been done on cucumber-html after 0.2.3 was released. What do you mean by "is not pulling in the correct version of formatter.js"?

Currently if you use 0.2.3, there is a Javascript error and the Cucumber report contains only the first line

Are you using cucumber-html from Cucumber? What flavour (I guess some JVM language) and version?

features/login.feature

Feature: Log in As a customer of NIB I want to be able to log into NIB So that I can view my account

... no further output

If I update to the latest formatter.js which includes the .before & .after block, that fixes this problem and the report is generated correctly

How did you update it exactly?

I'm running cucumber-jvm from Maven with dependency

info.cukes cucumber-html 0.2.3

You should not include cucumber-html as a direct dependency, as it is included by cucumber-core itself (see the java-helloworld example that produces an HTML output).

Paolo

PhilBaker13 commented 11 years ago

Hi Paolo,

Thanks for your response and help

You should not include cucumber-html as a direct dependency, as it is included by cucumber-core itself (see the java-helloworld example that produces an HTML output).

This was the issue. I have removed the cucumber-html dependency and update to cucumber-core version 1.1.4 (from version 1.1.3) and now the report is formatting properly

Thanks Phil

It seems 0.2.3 is not pulling in the correct version of formatter.js. Can we have a new 0.2.4 build that is correct?

Tried diffing formatter.js in the maven repository with the latest sources and there is no difference, and nothing has been done on cucumber-html after 0.2.3 was released. What do you mean by "is not pulling in the correct version of formatter.js"?

The version of formatter.js that is put into folder target/cucumber-report after the Maven run is not the latest, hence it causes the JavaScript error and the report is not formatted properly. I think this was because I thought formatter.js was coming from cucumber-html 0.2.3, but from your explanation it was actually coming from cucumber-core 1.1.3

Currently if you use 0.2.3, there is a Javascript error and the Cucumber report contains only the first line

Are you using cucumber-html from Cucumber? What flavour (I guess some JVM language) and version?

I'm using cucumber-jvm

features/login.feature

Feature: Log in As a customer of NIB I want to be able to log into NIB So that I can view my account

... no further output

If I update to the latest formatter.js which includes the .before & .after block, that fixes this problem and the report is generated correctly

How did you update it exactly?

We have a post-processing script that copies the latest formatter.js into folder target/cucumber-report

I'm running cucumber-jvm from Maven with dependency

info.cukes cucumber-html 0.2.3

You should not include cucumber-html as a direct dependency, as it is included by cucumber-core itself (see the java-helloworld example that produces an HTML output).

This was the problem! removing this dependency and updating to cucumber-core 1.1.4 solved it