Closed jowers closed 9 years ago
Not sure if this is the best place for these comments but I'm on my phone and can't see a better place (bit new to git hub)
Other than that it looks fine from a tcl point of view, there's a couple of things that could be changed for neatness sake but they don't really add anything to this feature so I don't think they are relevant. Specifically packaging over sourcing, avoid init on source and simplify the source_steps proc
Welcome to the project Jimmy!
Perfect place for the comments.
I think it makes sense for the Given/When/Then to be exported, so I'll do that now (I had to export the other 2 procs so that the call from ruby worked)
I'd be interested in seeing what it would look like with your other changes (i.e. packages, etc) - maybe we can get this change merged back and then you can create a branch with those modifications on?
Ok, I've made those changes (also removed the And proc which shouldn't be there, as in core cucumber, only Given, When and Then are valid step proc names).
@jimmydavies, @mattwynne are you ok for me to merge this one back?
OK with me.
Yeah, looks good to me On 4 Mar 2015 16:22, "Matt Wynne" notifications@github.com wrote:
OK with me.
— Reply to this email directly or view it on GitHub https://github.com/cucumber/cucumber-ruby-tcl/pull/21#issuecomment-77189825 .
I've modified framework.tcl to use namespaces instead of living in the global scope. All the tests passes, but I'll try to get someone else to have a look over it in case I've done something stupid.
Once this is done, we should be able to look at a more complete set of table functions.