Fix file sourcing order, source files in global namespace

brucepreston commented 9 years ago

Using Cucumber::Cli::Configuration.all_files_to_load to drive sourcing of Tcl files (rather than just scouring features/* for Tcl files).
Files now sourced in order: /support/env.tcl before /support/filename.tcl before */filename.tcl
Files are sourced into the global namespace (rather than the ::cucumber namespace).

jowers commented 9 years ago

@mattwynne would you be able to look at Bruce's suggested ruby changes for the ordering of file sourcing in cucumber-tcl?

mattwynne commented 9 years ago

Sorry I've not been paying attention - where are Bruce's suggestions?

jowers commented 9 years ago

Hi Matt,

Bruce's changes are in this commit: https://github.com/brucepreston/cucumber-ruby-tcl/commit/224dc48f32a4bd0b6c0e0b24271bf07940bab305

The idea is to tidy up the sourcing of files, following the cucumber "rules" for the ordering of files sourced.

mattwynne commented 8 years ago

LGTM! Want to merge it @jowers?

mattwynne commented 8 years ago

He's back! \o/

Typed with my Thumbs.

On 6 Mar 2016, at 19:50, jowers notifications@github.com wrote:

Closed #34 via 919e775.

— Reply to this email directly or view it on GitHub.

The Cucumber logo is the intellectual property of Cucumber Ltd, a limited company registered in Scotland, number 456793.

UK Headquarters: Cucumber Ltd, Drumsyniebeg, Lochgoilhead, Cairndow, Argyll, PA24 8AN UK.

CONFIDENTIALITY NOTICE: The information in this e-mail is confidential and privileged; it is intended for use solely by the individual or entity named as the recipient hereof. Disclosure, copying, distribution, or use of the contents of this e-mail by persons other than the intended recipient is strictly prohibited and may violate applicable laws. If you have received this e-mail in error, please delete the original message and notify us by email immediately. Thank you. Cucumber Ltd.

cucumber-attic / cucumber-ruby-tcl

Fix file sourcing order, source files in global namespace #34