Closed jowers closed 9 years ago
I've just checked in a couple of additional changes:
Anything else you think is needed for this one?
This looks good to me @jowers. Want to merge it into master with --squash
to keep the history nice and clean?
Done (I think) had to resolve conflicts in the README, but seems to have gone through.
Great!
Little bit of GitHub coaching: When you use --squash
you have to explicitly close the PR issue (GH does it automatically if you merge the whole PR branch without squashing). You can either do that by hand on the GitHub UI, or by mentioning closes #<PR or issue number>
in your commit message for the squashed merge commit.
The alternative to this is to rebase the PR branch until it's neat and tidy (using git rebase -i
and git push --force
) then you can just merge it in normally.
It's also good practice to delete the PR branch once it's merged in to keep the repo tidy. I normally forget to do this - see how many dead branches there are in cucumber/cucumber, for example.
Here's my first attempt at allowing parameters in a step definition...