Step defs with parameters

cucumber-attic / cucumber-ruby-tcl

Tcl bindings for Cucumber

MIT License

9 stars 6 forks source link

Step defs with parameters #9

Closed jowers closed 9 years ago

jowers commented 9 years ago

Here's my first attempt at allowing parameters in a step definition...

jowers commented 9 years ago

I've just checked in a couple of additional changes:

Renamed the new scenario as suggested above
Added a unit test to cover the case that _add_steps is called with more than 3 parameters
Updated _add_steps to raise an error if it is called with more than 3 parameters
Updated the README to include examples with variables to match a regexp

Anything else you think is needed for this one?

mattwynne commented 9 years ago

This looks good to me @jowers. Want to merge it into master with --squash to keep the history nice and clean?

jowers commented 9 years ago

Done (I think) had to resolve conflicts in the README, but seems to have gone through.

mattwynne commented 9 years ago

Great!

Little bit of GitHub coaching: When you use --squash you have to explicitly close the PR issue (GH does it automatically if you merge the whole PR branch without squashing). You can either do that by hand on the GitHub UI, or by mentioning closes #<PR or issue number> in your commit message for the squashed merge commit.

The alternative to this is to rebase the PR branch until it's neat and tidy (using git rebase -i and git push --force) then you can just merge it in normally.

mattwynne commented 9 years ago

It's also good practice to delete the PR branch once it's merged in to keep the repo tidy. I normally forget to do this - see how many dead branches there are in cucumber/cucumber, for example.