search

cucumber-attic / cucumber-tmbundle

TextMate bundle for Cucumber
http://www.benmabey.com
MIT License
204 stars 54 forks source link

Modified 'Autoformat Feature' command to work better #15

Closed int3h closed 13 years ago

int3h commented 13 years ago

I modified the "Autoformat Feature (using Cucumber)" to tell TextMate to reload the file after it has been formatted, and to play nice with RVM. Includes RVM and RSPEC 2 fixes.

diabolo commented 13 years ago

6bbd14a causes 21 unit tests to fail, I like the idea of dealing with path with spaces but this fix is to dangerous to accept

67ec793 doesn't explain what its doing with the plist so I wouldn't want to commit that bit. The change to the auto command passes the unit tests, but the current version is somewhat changed from what you modified. If you would like to submit this fix separately, with an accompanying unit test that fails with the current head and passes with your fix that would be great.

6c9c788 is in :)

f806f80 would be nice if you could resubmit separately with the autocomplete step done and other steps that need doing. I guess this should be done before 67ec793

302108a would be happy to accept with a unit test. I haven't used autoformat and after a cursory look at it, it doesn't seem to do anything at all.

ee89890 I'm pretty sure this isn't really required as master works fine with rvm and bundler

Thanks for you pull request and apologies for delay in dealing with this - I've been looking after this project for less than a week!

int3h commented 13 years ago

Thanks for checking this out. Unfortunately, I am currently swamped with other work right now. When I have some more free time (mid-July, maybe?) I will re-examine your suggested changes to 67ec793 when I have the time then, and hopefully get it fixed up and in as another pull request. Ditto the other commits, too.

Thanks for working on this project, we all appreciate it.