Request for adding Thai language in i18n

[roofimon]

Requesting for add Thai language into i18n system.

[os97673]

Please fix the test which is failing with your changes.

[roofimon]

ok i got it, will fix it On Apr 11, 2013 11:21 PM, "Oleg Sukhodolsky" notifications@github.com wrote:

Please fix the test which is failing with your changes.

— Reply to this email directly or view it on GitHubhttps://github.com/cucumber/gherkin/pull/250#issuecomment-16237285 .

[roofimon]

Dear Oleg Last night i trying to call "rake" after I clone gherkin into my laptop (without changing anything) but this is what I found.

roofimon@Twins-MacBook-Pro ~/Workspaces/Odd-e/gherkin [master] ± % rake --trace

                                        !3233

mkdir -p /Users/roofimon/Workspaces/Odd-e/ cucumber.github.com/api/gherkin/2.11.8/ruby /Users/roofimon/Workspaces/Odd-e/gherkin/tasks/ragel_task.rb:25: Use RbConfig instead of obsolete and deprecated Config. * Invoke default (first_time) * Invoke spec (first_time) * Invoke compile (first_time) * Invoke lib/gherkin/lexer/zh_tw.rb (first_time) * Invoke /Users/roofimon/Workspaces/Odd-e/gherkin/tasks/../ragel/i18n/zh_tw.rb.rl (first_time, not_needed) * Invoke /Users/roofimon/Workspaces/Odd-e/gherkin/tasks/../ragel/lexer.rb.rl.erb (first_time, not_needed) * Invoke /Users/roofimon/Workspaces/Odd-e/gherkin/tasks/../ragel/i18n/lexer_common.zh_tw.rl (first_time, not_needed) * Invoke /Users/roofimon/Workspaces/Odd-e/gherkin/tasks/../ragel/lexer_common.rl.erb (first_time, not_needed) \ Execute lib/gherkin/lexer/zh_tw.rb ragel -R /Users/roofimon/Workspaces/Odd-e/gherkin/tasks/../ragel/i18n/zh_tw.rb.rl -o lib/gherkin/lexer/zh_tw.rb rake aborted!

Is there any recommendation for me? Thanks roof

On Thu, Apr 11, 2013 at 11:21 PM, Oleg Sukhodolsky <notifications@github.com

wrote:

Please fix the test which is failing with your changes.

— Reply to this email directly or view it on GitHubhttps://github.com/cucumber/gherkin/pull/250#issuecomment-16237285 .

Write Code Not War

[os97673]

It looks like you do not have ragel installed. Check "Hacking: Installing the toolchain" section of https://github.com/cucumber/gherkin/blob/master/README.md

[os97673]

I've tried to merge the change manually (and fix the test) but noticed that there is no changes except new test. @roofimon have you remove the changes?

[roofimon]

Dear Oleg Yes I removed it after I tried to run test against my change but I failed and I didn't know how to fix it. Can I tried one one more time? BR roof

On Thu, Apr 18, 2013 at 3:01 AM, Oleg Sukhodolsky notifications@github.comwrote:

I've tried to merge the change manually (and fix the test) but noticed that there is no changes except new test. @roofimon https://github.com/roofimon have you remove the changes?

— Reply to this email directly or view it on GitHubhttps://github.com/cucumber/gherkin/pull/250#issuecomment-16532123 .

Write Code Not War

[os97673]

Can I tried one one more time?

sure

[aslakhellesoy]

@roofimon don't worry about getting tests to pass. Just re-submit your Thai translation and we'll do the rest.

[roofimon]

roger that

On Tue, Apr 23, 2013 at 2:54 AM, Aslak Hellesøy notifications@github.comwrote:

@roofimon https://github.com/roofimon don't worry about getting tests to pass. Just re-submit your Thai translation and we'll do the rest.

— Reply to this email directly or view it on GitHubhttps://github.com/cucumber/gherkin/pull/250#issuecomment-16818380 .

Write Code Not War

[roofimon]

Already send pull request Thank you

On Tue, Apr 23, 2013 at 2:54 AM, Aslak Hellesøy notifications@github.comwrote:

@roofimon https://github.com/roofimon don't worry about getting tests to pass. Just re-submit your Thai translation and we'll do the rest.

— Reply to this email directly or view it on GitHubhttps://github.com/cucumber/gherkin/pull/250#issuecomment-16818380 .

Write Code Not War

[os97673]

closed with #253