search

cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)
MIT License
382 stars 221 forks source link

Update i18n.json #290

Closed rasheedbutt closed 10 years ago

rasheedbutt commented 10 years ago

adding Urdu support

aslakhellesoy commented 10 years ago

Urdu! About time :-)

Thanks a lot

os97673 commented 10 years ago

The build is failing :( Could you please fix this.

aslakhellesoy commented 10 years ago

The people who are contributing translations aren't necessarily the people who will run all the tests and make sure the PR is clean. It's very common that translation PRs break the build.

Instead of asking people who contribute translations to fix the build (unlikely to happen, time consuming) we should change our tests so that new translations can be added without breaking the build.

brasmusson commented 10 years ago

@aslakhellesoy @os97673 I've made some changes to those test cases that breaks when new languages are added, so that they do some sanity checks but does not need to be updated for each new language. I'll put up the changes as a PR tomorrow or so.

brasmusson commented 10 years ago

In this particular case the first commit https://github.com/rasheedbutt/gherkin/commit/1b2cfc6ba6cd6c74721fc02449d772361bf0d228 works fine (except for the infamous test of language listings), but the second commit https://github.com/rasheedbutt/gherkin/commit/c05eab4f809e4e7845f902da6625c9dd4fcd7cd6 changes the file encoding from utf-8-unix to utf-8-with-signature-unix and need to be reverted/excluded.

os97673 commented 10 years ago

@brasmusson thank you for finding the cause of the problem. I've fixed it and pushed. @rasheedbutt thank you for the contribution