search

cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)
MIT License
382 stars 221 forks source link

Update i18n.json #296

Closed umajeric closed 10 years ago

umajeric commented 10 years ago

Added Slovenian language

os97673 commented 10 years ago

@umajeric the patch break the build please fix it

umajeric commented 10 years ago

I have fixed it. Sorry for that.

os97673 commented 10 years ago

still failing :(

umajeric commented 10 years ago

Should be ok, I have fixed some formatting and validated the file using http://jsonformatter.curiousconcept.com/ and it says all is ok.

All best

brasmusson commented 10 years ago

@umajeric You have not updated the test case for the listing of available languages, it does not expect the Slovenian langage, and it is now failing, see the log on Travis

umajeric commented 10 years ago

Sorry not familiar with ruby. I hope it is well now.

brasmusson commented 10 years ago

@umajeric Now I see that also the (Java) test shouldFindAllLanguages needs to be updated to also expect the Slovenian language. Therefore the JRuby build still fails on Travis (the two Ruby builds that does not execute the Java test are passing).

aslakhellesoy commented 10 years ago

I think we should relax those tests so that it's easier to add a new translation without having to update tests

umajeric commented 10 years ago

I have fixed the java test, I have no idea what else to fix for ruby tests. I can fix it if you give me a tip.

br

brasmusson commented 10 years ago

@umajeric If you look at the green "√" (which is also a link to the Travis build) beside your latest commit id ff513be, you see that all builds are passed. Nothing more needs to be done. Thanks.

os97673 commented 10 years ago

Thank you for the contribution.

umajeric commented 10 years ago

OK, you are welcome. Once again sorry for failed tests.

Enjoy, Uros