Issue #309 - Makes I18n.get raises correctly when receiving invalid iso_code

cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)

MIT License

382 stars 221 forks source link

Issue #309 - Makes I18n.get raises correctly when receiving invalid iso_code #310

Open abinoam opened 10 years ago

abinoam commented 10 years ago

See #309

abinoam commented 10 years ago

Failed at JRuby. I'll take a look at it.

abinoam commented 10 years ago

Took a look and it seems it fails on Java code. I have no good expertise in Java, sorry.

os97673 commented 10 years ago

JRuby version is failing on Travis :( You need to provide java implementation too.

abinoam commented 10 years ago

Updating PR soon.

abinoam commented 10 years ago

Now it is passing on Travis. Could you reevaluate the Pull Request?

os97673 commented 10 years ago

looks fine for me. @aslakhellesoy are we going to release next gherkin from master? If so when? I do not like idea to merge fix whig will never be fixed :(