search

cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)
MIT License
382 stars 221 forks source link

Added basic confluence markup support (tested with confluence 4.2.12) #321

Closed plafue closed 9 years ago

aslakhellesoy commented 9 years ago

Hi @plafuro this looks awesome!

I'm a little skeptical about including it in the Gherkin library though - I think this might be better to implement as a separate module in Cucumber-JVM - cucumber-confluence perhaps?

plafue commented 9 years ago

Hi @aslakhellesoy ! thank you for the quick feedback!

I totally understand your point. I created a new cucumber-confluence repo with a Formatter and an additional CLI. I still kept a dependency on gherkin, though, to make sure that I use the interfaces set by that project.

I left the maven groupIds, package names, etc. under the same namespace as your project. If this is not desired let me know.

Cheers, P

aslakhellesoy commented 9 years ago

Thanks!

The existing package names and group ifs are owned by the cucumber organisation, so please rename both.

Alternatively I suggest you add it to the cucumber-jvm project, which consists of several modules. In that case I'd be ok with keeping the cucumber package and info.cukes group id.

plafue commented 9 years ago

Hi again Aslak.

Thanks a lot for your input. As suggested i moved away from the info.cukes and cucumber namespaces. I will continue working on my repository and will open a new pull request once i'm comfortable with the end result. We can also discuss then where would a good location for the project under cucumber-jvm.

Cheers, P