cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)
MIT License
382 stars 221 forks source link

Add "Zakładając że" keyword to polish translation #325

Closed marek-pietrzak-tg closed 9 years ago

marek-pietrzak-tg commented 9 years ago

"Zakładając że" means in polish "Given that". The main difference between Polish and English is that adding "że" completely changes the order of the sentence.

Sometimes it's more natural to use zakładając że rather just zakładając|mając, e.g. Zakładając że jestem zalogowany jako "administrator" (Given that I am logged in as an "administrator").

If you remove "że" from this sentence it has to become something like: Zakładając zalogowanego użytkownika jako "administrator" (Given there is a user logged in as an "administrator"), which in Polish sounds odd.

There is no easy way to just remove "że", as you could do it in English with removing "that" word.

We could of course always write że after a keyword, when we need it, but this leads to another issue - unnecessary ze in method names and regexp.

czogori commented 9 years ago

Because of grammatical correctness it should look like this "Zakładając, że"

marek-pietrzak-tg commented 9 years ago

@czogori using punctuation here is a good idea :+1:

aslakhellesoy commented 9 years ago

Applied to cucumber/gherkin3@7d6645617cbb1fed6aa61fbb49726741a485a54a Thanks!