search

cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)
MIT License
382 stars 221 forks source link

Added English Simplified to the language choices #326

Closed kyleprins closed 9 years ago

kyleprins commented 9 years ago

replaces the Given, Then, When, And, But keywords with Step

aslakhellesoy commented 9 years ago

Sounds like something we don't want. I can't see how this promotes good language and living documentation.

dkowis commented 9 years ago

Yeah I'm :-1: on this as well. Why should we pull this in, @kyleprins ?

kyleprins commented 9 years ago

Since cucumber is treating these keywords as generic and interchangeable it would be nice to have the option to just use a generic step keyword as a sort of verbal bullet point instead of writing everything in the "Given", "When", "Then" form. This seemed to be the easiest way to do it.

I understand if you don't feel that this fits the ideas behind gherkin. I would find it useful for some of the tests I am writing so I figured it was worth putting in the request.

mattwynne commented 9 years ago

Did you know you can literally use an asterisk as a bullet point, instead of Given / When / Then / And / But?

I don’t understand how the word “Step” works as a verbal bullet point. Can you give me an example of how you’d use it?

kyleprins commented 9 years ago

I did not know that you could use an asterisk. That will work perfectly for my needs.
Knowing that, I agree that this adds nothing to Gherkin and you shouldn't merge it. Thank you for your help.