search

cucumber-attic / gherkin2

A fast Gherkin parser in Ragel (The parser behind Cucumber)
MIT License
382 stars 221 forks source link

RCov is not supported anymore for recent ruby #345

Open sponte opened 8 years ago

sponte commented 8 years ago

Removing Rcov from rake task as it causes a build to break. Given @aslakhellesoy is working on gherkin3 there is not much point fixing this.

The only reason I am raising this pull request is to build current version of gherkin which fixes propagating tags in example groups to Before hooks in cucumber-jvm.

sponte commented 8 years ago

Hi @aslakhellesoy, I have "fixed" gherkin2 build by removing rcov and fixing bundler version to work properly on travis. It builds successfully now in CI. I know there is big push for gherkin3 but this build willl fix a bug with example tables and tags not being propagated to before/after hooks.

Do you have a separate release process for bumping versions up? I haven't touched any of the version files in the source. Let me know and I can update PR if required.

Best regards, Stan

aslakhellesoy commented 8 years ago

Hi @sponte we won't be making any more releases of gherkin2.

Cucumber-ruby uses gherkin3 now, and Cucumber-JVM, Cucumber-JS and SpecFlow are being updated to gherkin3 too.

aslakhellesoy commented 8 years ago

Is there a bug report anywhere in Cucumber-JVM explaining what's wrong with example tables and tags not being propagated to hooks and how to reproduce it?

Do you believe #286 (which is currently not released) fixes this?

sponte commented 8 years ago

Yes. This PR fixes the issue. It was already implemented but never released hence I was trying to fix the build.

On 2 Feb 2016, at 07:00, Aslak Hellesøy notifications@github.com wrote:

Is there a bug report anywhere in Cucumber-JVM explaining what's wrong with example tables and tags not being propagated to hooks and how to reproduce it?

Do you believe #286 (which is currently not released) fixes this?

— Reply to this email directly or view it on GitHub.