cucumber-rs / cucumber

Cucumber testing framework for Rust. Fully native, no external test runners or dependencies.
https://cucumber-rs.github.io/cucumber/main
Apache License 2.0
579 stars 70 forks source link

Neither feature nor scenario headings are printed after updating to 0.20 #299

Closed serzhshakur closed 1 year ago

serzhshakur commented 1 year ago

After updating to cucumber-rs 0.20 neither feature, nor scenario, nor rule headings are printed to a console when running tests with colored output. See the comparison below:

However heading are printed when running tests with --color=never

image

You can check this repo for the reference

serzhshakur commented 1 year ago

Probably related to https://github.com/cucumber-rs/cucumber/issues/282

zohnannor commented 1 year ago

I've bisected the commits between https://github.com/cucumber-rs/cucumber/releases/tag/v0.20.0 and https://github.com/cucumber-rs/cucumber/releases/tag/v0.19.0. This and this are changes (introduced in #258) that seem to cause the new, wrong behavior. As I don't know the exact reasoning behind those changes, I'll ping @ilslv for elaboration/investigation :slightly_smiling_face:

berkes commented 1 year ago

Probably related: tracing output gets overwritten by this same "bug" it seems. Disabling color keeps the tracing output, enabling color overwrites it with blank lines.

tyranron commented 1 year ago

@serzhshakur @berkes released as 0.20.1.

serzhshakur commented 1 year ago

Great, thank you, works as expected now 👍