cucumber / aruba

Test command-line applications with Cucumber-Ruby, RSpec or Minitest.
MIT License
948 stars 163 forks source link

Cucumber step to run literal script broken on Windows #521

Open UltimateGeek opened 6 years ago

UltimateGeek commented 6 years ago

Summary

On Windows, Aruba fails to run the temporary script it creates from:

When I run the following commands:
  ```
  echo foo
  ```

Expected Behavior

Then the output should contain "foo"

Current Behavior

The step fails with output:

Command "myscript" not found in PATH-variable "C:/...

Your Environment

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

UltimateGeek commented 6 years ago

The problem is cmd.exe on Windows needs to be given a full or relative path to the script created.

mvz commented 6 years ago

Windows support is rather experimental I'm afraid. I'll see what I can do. Which version of Aruba are you using?

UltimateGeek commented 6 years ago

Version used: 1.0.0.pre.alpha.2

Thank you @mvz

MartyGentillon commented 6 years ago

I see the same on 0.14.5.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

mvz commented 3 years ago

I think the generated script should be named myscript.bat on Windows.