cucumber / aruba

Test command-line applications with Cucumber-Ruby, RSpec or Minitest.
MIT License
949 stars 163 forks source link

Clean up output matchers #545

Open mvz opened 6 years ago

mvz commented 6 years ago

Summary

There are several matchers defined by Aruba that are very similar to matchers provided by RSpec. For example:

Expected Behavior

Aruba should use default RSpec matchers where possible to make its internal code comprehensible and to provide good examples for its users. Also, Aruba should not define generic matchers that may have to be supported beyond their internal use.

Current Behavior

There's a proliferation of matchers that increase the maintenance burden.

Possible Solution

Remove matchers that don't pull their weight.

Context & Motivation

Improving the output of failing steps is hard because there are many custom matchers that all need to be checked.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

xtrasimplicity commented 6 years ago

Bumped.