search

cucumber / commitbit

Microservice that hands out commit bit to everyone who gets a pull request merged
2 stars 1 forks source link

Mistakenly sending out welcome messages to existing team members #6

Open mattwynne opened 7 years ago

mattwynne commented 7 years ago

I'm not sure why, but @danascheider, who's been a member of the cucumber-ruby core team for some time, just got an invite when I merged her PR:

https://github.com/cucumber/cucumber-ruby/pull/1187#issuecomment-327037663

No real harm done but it looks a bit silly!

aslakhellesoy commented 7 years ago

It sends the message if the committer isn't already a member of the committers team. Maybe she had fallen off when I reorged the teams a few weeks back? I'll look into this.

mattwynne commented 7 years ago

@aslakhellesoy I think it might be that Dana's in one of those inner core teams, and might not be explicitly in that outer committer team.

aslakhellesoy commented 7 years ago

She would have been added by the commitbit now though

aslakhellesoy commented 7 years ago

Or did it happen a 2nd time?

mattwynne commented 7 years ago

I only saw it once.

mpkorstanje commented 4 years ago

Another example https://github.com/cucumber/cucumber-jvm/pull/1658

Seems to be triggered by lockbot.