search

cucumber / common

A home for issues that are common to multiple cucumber repositories
https://cucumber.io/docs
MIT License
3.36k stars 694 forks source link

Json-formatter detected as trojan horse #1681

Closed s-burtonshaw closed 3 years ago

s-burtonshaw commented 3 years ago

Describe the bug The executable cucumber-json-formatter-windows-amd64 v7.01 is being detected as Trojan named Artemis!2DD068390E80 by McAfee Antivirus software.

To Reproduce Steps to reproduce the behavior:

  1. On Windows system with McAfee antivirus attempt to download latest version of cucumber-json-formatter
  2. Attempt to use/rename exe
  3. McAfee on-access scan detects trojan (and deletes exe)

Expected behavior No detection.

Context & Motivation We are using cucumber-json-formatter in our AzureDevops release pipeline to generate a HTML report. We are using it to convert ndjson results from cucumber to JSON to be consumed by this extension which in turn uses this node package.

We are using a previous version of cucumber-json-formatter (unsure what version as I can't see any version info on the exe) and this is not detected by McAfee but wanted to try the latest version I was trying to get screenshots to show on failed steps (not even sure this new version will help with that problem yet)

Screenshots image

Your Environment

I will start looking at alternative for generating the HTML report but thought this was worth mentioning.

aurelien-reeves commented 3 years ago

Hi, and thanks for your report.

This is because that standalone json-formatter is written in Go. Go often triggers false-positives on Windows. Refs. https://golang.org/doc/faq#virus

The only thing that could be done may be to send a report to McAfee.

Please note that we have recently decided to undeprecate built-in json formatters. We won't enhanced them, but we won't remove them either. That means that you can actually rely on the report that --format json will generate.

aslakhellesoy commented 3 years ago

Can we close this?