cucumber / common

A home for issues that are common to multiple cucumber repositories
https://cucumber.io/docs
MIT License
3.36k stars 695 forks source link

Gherkin Lint - New project? #59

Closed aslakhellesoy closed 6 years ago

aslakhellesoy commented 8 years ago

A recent discussion in the cucumber/gherkin gitter room revealed that there are (at least) 3 Cucumber linters out there:

The projects are similar, and I think there are some great unique things in each one of them.

What do you think about joining forces to create a single one to rule them all? Ideally in JavaScript since it's easier to use on the web, and also relatively easy to embed into other libraries as well as editors and IDEs.

If you're interested, just reply here and fill out this doodle for a google hangout kickoff meeting.

/cc @enkessler @allustin @vsiakka @r-cochran

ghost commented 8 years ago

i am interested.

found another projects

may be dead

https://github.com/wimpheling/codemirror-gherkin-linter https://github.com/mekentosj/ling

on ruby with some usefull checks

https://github.com/funkwerk/gherkin_lint#checks

vsiakka commented 8 years ago

I am interested!

Pr-Mex commented 8 years ago

+1

r-cochran commented 8 years ago

I am interested

aslakhellesoy commented 8 years ago

Thanks for doodling everyone. I've picked a time the upcoming Friday.

Proposed agenda

We'll take lo-fi minutes in gitter and paste a summary in this ticket later.

Homework before hangout

Study the various implementations listed above and write down a list of things you'd like to see in the official implementation. This will help us come up with better goals.

Thanks for participating everyone - I'm really excited about this!

AlexeyBuzdin commented 8 years ago

Will be glad to join!

enkessler commented 8 years ago

Good to go!

aslakhellesoy commented 8 years ago

There is also @charlierudolph's https://github.com/charlierudolph/cucumber_lint that we can use as inspiration

aslakhellesoy commented 8 years ago

Some of us ran a Google Hangout meeting on 12th Aug 2016. The minutes are here.

aslakhellesoy commented 8 years ago

I just fixed the sharing access of that google doc. Anyone with the link can see it and comment on it.

gmk1217 commented 8 years ago

Hi Cukes, https://github.com/cucumber/gherkin-lint

Is this link working? got 404 error.


Mohan Krishna Gundala [image: https://]about.me/gmk.india https://about.me/gmk.india?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

On Wed, Sep 14, 2016 at 6:13 PM, Aslak Hellesøy notifications@github.com wrote:

I just fixed the sharing access of that google doc. Anyone with the link can see it and comment on it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cucumber/cucumber/issues/59#issuecomment-247000613, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIicRbbKISIh8tMt7oAJtUrTruOB9zIks5qp-vfgaJpZM4Jes1Y .

aslakhellesoy commented 8 years ago

@gmk1217 where did you find a broken link to https://github.com/cucumber/gherkin-lint ?

(The correct link is https://github.com/cucumber/gherkin-lint-javascript)

gmk1217 commented 8 years ago

it's the google doc which you have shared

https://docs.google.com/document/d/16phGnd-hd2GcN118Irn1ccpm-4JqBB9wfBVB9cXDIIo/edit#


Mohan Krishna Gundala [image: https://]about.me/gmk.india https://about.me/gmk.india?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

On Wed, Sep 14, 2016 at 7:03 PM, Aslak Hellesøy notifications@github.com wrote:

@gmk1217 https://github.com/gmk1217 where did you find a broken link to https://github.com/cucumber/gherkin-lint ?

(The correct link is https://github.com/cucumber/gherkin-lint-javascript)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cucumber/cucumber/issues/59#issuecomment-247013799, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIicdwGcpkBBglJkyNU4mWLDXt1Njveks5qp_eZgaJpZM4Jes1Y .

aslakhellesoy commented 7 years ago

Here is another one: https://github.com/wesovilabs/gherkinize by @ivancorrales

I'll let everyone in this issue know when gherkin-lint is open for contribution - been busy doing other things (such as adding event protocol support to gherkin, which will simplify gherkin-lint architecture considerably)

igas commented 6 years ago

@aslakhellesoy it's great that you are working on consolidation of linters. Thanks for all your work. Do you have any project updates?

aslakhellesoy commented 6 years ago

I haven't made any progress I'm afraid. Too many other responsibilities.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

enkessler commented 6 years ago

One more gherkin linter. This is one is also in Ruby but is actively maintained.

DwordPtr commented 6 years ago

As I created the issue above. I am interested. How much work/process would it take to bring the gherkin-lint npm package into the monorepo?

Doubtless there will be stuff we don't like but having a starting spot that already works.

Goes without saying I don't mind helping out where I can (and am qualified to)

enkessler commented 6 years ago

Setting aside the risk of my participation giving the project the touch of death, I remain more than happy to help in a limited capacity (I've never made an NPM package before).

DwordPtr commented 6 years ago

I made a super simple one to try it out. The tooling is pretty nice. The hardest part is knowing what the ast will look like in a dynamically typed language.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

stale[bot] commented 6 years ago

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.