CCK: Reconcile rules - Githubissues

cucumber / compatibility-kit

Platform-agnostic set of acceptance tests for validating cucumber implementations

https://cucumber.io/

MIT License

1 stars 4 forks source link

CCK: Reconcile rules #76

Closed luke-hill closed 11 months ago

luke-hill commented 12 months ago

rules is now is consistent for ruby/js.

I also massively removed the contradictory steps. Now it's at least consistent.

⚡️ What's your motivation?

Goes towards completion of issue in tracker

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
:bug: Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [ ] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[ ] Users should know about my change
- [ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

luke-hill commented 12 months ago

@davidjgoss think my knowledge of the assert library might be a bit lacking here. This will probably need a fix. I couldn't find a beEmpty() function