[cmake] adding a target install

cucumber / cucumber-cpp

Support for writing Cucumber step definitions in C++

MIT License

306 stars 131 forks source link

[cmake] adding a target install #182

Closed matlo607 closed 6 years ago

matlo607 commented 6 years ago

I propose to add a target install to CMakeLists.txt

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
[x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
[x] I've added tests for my code.
[x] I have verified whether my change requires changes to the documentation
[x] My change either requires no documentation change or I've updated the documentation accordingly.
[x] My branch has been rebased to master, keeping only relevant commits.

matlo607 commented 6 years ago

@paoloambrosio, @muggenhor or @konserw : could you please review the pull request ? Please ignore the commit https://github.com/cucumber/cucumber-cpp/pull/182/commits/3887d2cd85ea712c67aea29bc1362b78d73c88eb, konserw told me it's wrong. I will wait for #184.

coveralls commented 6 years ago

Coverage remained the same at 62.814% when pulling edea427ce85d37640dc049b28ed94d786fee43e4 on matlo607:cmake-add-target-install into 870bfc2cd02180397ee7f8d9b25d823e7998037a on cucumber:master.

konserw commented 6 years ago

@matlo607 could you please rebase this branch onto master now that it is fixed? Also please drop commmit 8076700

matlo607 commented 6 years ago

Hello @konserw, I rebased the branch and removed 8076700

aslakhellesoy commented 6 years ago

Hi @matlo607,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber