Fix #203: QtTestCalculatorQtSteps is not generated because of a typo in CMakeLists.txt

ghost commented 5 years ago

Summary

Fix a typo that prevents build/examples/CalcQt/QtTestCalculatorQtSteps from being generated.
It is, however, leaking memory. See #212

How Has This Been Tested?

Clone and build with examples, look for build/examples/CalcQt/QtTestCalculatorQtSteps. It is missing. Apply this change, rebuild, it appears.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
[x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
[ ] I've added tests for my code.
[x] I have verified whether my change requires changes to the documentation
[x] My change either requires no documentation change or I've updated the documentation accordingly.
[x] My branch has been rebased to master, keeping only relevant commits.

coveralls commented 5 years ago

Coverage remained the same at 62.456% when pulling d22e3212afb48ff5234f3211634b9de12a9232f5 on sergey-bon:patch-1 into 04629341884d4f41019d12bbbfb405e1301b9e5d on cucumber:master.

ghost commented 5 years ago

@paoloambrosio is it okay to merge?

paoloambrosio commented 5 years ago

Pretty sure the build is going to fail unless we merge #218 first. I'll try and merge a few PRs later today.

paoloambrosio commented 5 years ago

Should we remove -f "${TEST}" -a in travis.sh to have the build fail if the file is not created?

paoloambrosio commented 5 years ago

Can you rebase this to my verify-pr-208 branch?

It makes the build fail unless your patch is applied.

ghost commented 5 years ago

@paoloambrosio done

paoloambrosio commented 5 years ago

Something went wrong in the rebase. It should look something like this branch: https://github.com/paoloambrosio/cucumber-cpp/commits/sergey-bon-patch-1-rebased

From current master it should add my commit 91033b8 and your e4700dc. This contains also other three commits.

ghost commented 5 years ago

That's because I rebased on both verify-pr-208 and master at first.

I've pulled master, re-applied fix, and rebased on verify-pr-208. It should be fine now.

cucumber / cucumber-cpp