Fix #207, close #195: Build problems when unit tests or examples are enabled (clang, Visual Studio)

cucumber / cucumber-cpp

Support for writing Cucumber step definitions in C++

MIT License

308 stars 131 forks source link

Fix #207, close #195: Build problems when unit tests or examples are enabled (clang, Visual Studio) #209

Closed ghost closed 5 years ago

ghost commented 5 years ago

Regarding issue with clang #207 and Visual Studio #195

References: https://stackoverflow.com/questions/43282826/ http://www.gotw.ca/publications/mill18.htm

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 62.485% when pulling 96d7538af42529be326de4d3fbeaec79833ad270 on sergey-bon:fix-issue-195 into f79990879a3c2eea288de6efeefc4008937300cc on cucumber:master.

paoloambrosio commented 5 years ago

Thanks for contribution and links.

I'd rather keep #195, given that there is no real reason to prevent destruction from base pointer, so I'll close this in favour of the earlier PR.