Fix regression on optional regex submatches

ala-ableton commented 5 years ago

Summary

Fixes a regression that was introduced in commit a7ff906 (Regex: use iterators for match results).

Details

Until commit a7ff906, the vector returned by RegexMatch::getSubmatches() contained an empty string item for each optional submatch that didn't match. Commit a7ff906 broke that behavior by skipping any submatch that didn't match.

How Has This Been Tested?

I added a test (matchesRegexWithOptionalSubmatches) to tests/unit/RegexTest.cpp. I cherry-picked this test on top of 4dec371ca9a379cf762b32e94949d2bd39f2d77e (the parent commit of a7ff906ab379a055f4d9d06e1efdf00fc9434e72) and verified that it was passing. I then verified that this test doesn't pass on top of the latest master without the corresponding change in src/Regex.cpp.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
[x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
[x] I've added tests for my code.
[x] I have verified whether my change requires changes to the documentation
[x] My change either requires no documentation change or I've updated the documentation accordingly.
[x] My branch has been rebased to master, keeping only relevant commits.

ala-ableton commented 5 years ago

I have no clue about whether I should make any changes to the documentation (including CHANGELOG.md), so I left the 2 check boxes un-ticked for now.

coveralls commented 5 years ago

Coverage increased (+0.01%) to 62.47% when pulling e7b8f641ebf939380d7e6c8ce217b8cfcbf7e808 on AbletonAppDev:fix-regression-on-optional-regex-submatches into ee740d25d1598c2adfb509cf1f08f199239d88a9 on cucumber:master.

ala-ableton commented 5 years ago

Following the recent merges of #216 and #215, I've rebased and force-pushed my branch. @muggenhor, @paoloambrosio: please review, thanks!

ala-ableton commented 5 years ago

@muggenhor: thank you for the review! Can you take care of merging this PR, or should we wait for @paoloambrosio to also have a look?

muggenhor commented 5 years ago

I'll ~~probably~~intend to merge it somewhere later this week

aslakhellesoy commented 5 years ago

Hi @ala-ableton,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

cucumber / cucumber-cpp