Support step definitions with multi-byte characters

rkk-ableton commented 5 years ago

Summary

This branch adds support for handling characters outside of the Unicode block 'Basic Latin' by updating json-spirit to the latest version and modifying cucumber-cpp to properly handle this change.

Motivation and Context

This change adds support for passing raw UTF-8 strings from cucumber-cpp to cucumber-ruby which is necessary when writing tests which use non-'Basic Latin' characters to validate application behavior.

This relates to and resolves #40.

How Has This Been Tested?

This branch adds three new tests (5fff48f).

These tests were run following cucumber-cpp's own instructions for building and testing.

While commit 5fff48f is checked out, the tests, which demonstrate incorrect behavior, pass.
Commit 581b3c8 updates the WireProtocolTest in addition to modifying the WireResponseEncoder::encode. The modified test, demonstrating correct behavior, passes.
Commit 1c0a1bd modifies the other two tests to demonstrate the corrected RegEx match results.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
[x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
[x] I've added tests for my code.
[x] I have verified whether my change requires changes to the documentation
[x] My change either requires no documentation change or I've updated the documentation accordingly.
[x] My branch has been rebased to master, keeping only relevant commits.

coveralls commented 5 years ago

Coverage increased (+0.03%) to 62.503% when pulling 1c0a1bdf6097dc95970fc2afd490699c6ae7d7f5 on AbletonAppDev:update-json-spirit-upstream into dd424c1a900cb41c5db9d481714eb3471ce195e3 on cucumber:master.

rkk-ableton commented 5 years ago

RFC @muggenhor & @paoloambrosio.

rkk-ableton commented 5 years ago

All json_spirit files went from 644 to 755.

@paoloambrosio I fixed up the commit updating json_spirit. This should now be resolved.

rkk-ableton commented 5 years ago

Hi @paoloambrosio,

I believe the change you requested has been addressed. Is there anything else you'd like changed before this is merged?

Thank you!

rkk-ableton commented 5 years ago

Hi @paoloambrosio, I wanted to try and ping you one more time to check if you'd like any more changes to the branch prior to merging.

Thanks!

rkk-ableton commented 3 years ago

Hi @muggenhor, @paoloambrosio, @konserw, this issue has come up again. Would you consider merging this PR?

paoloambrosio commented 3 years ago

I'm not maintaining this repo anymore. From a quick scan it looks good to me. I'll leave it to the new maintainer @jermus67 to review and merge.

aslakhellesoy commented 3 years ago

Hi @src-ableton,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

rkk-ableton commented 3 years ago

@aslakhellesoy Thanks for the invitiation to the organization! I was unable to accept, however, having been on vacation the last three weeks. Could you please re-send the invite?

aslakhellesoy commented 3 years ago

@src-ableton done!

cucumber / cucumber-cpp