Closed rkk-ableton closed 3 years ago
RFC @muggenhor & @paoloambrosio.
All
json_spirit
files went from 644 to 755.
@paoloambrosio I fixed up the commit updating json_spirit. This should now be resolved.
Hi @paoloambrosio,
I believe the change you requested has been addressed. Is there anything else you'd like changed before this is merged?
Thank you!
Hi @paoloambrosio, I wanted to try and ping you one more time to check if you'd like any more changes to the branch prior to merging.
Thanks!
Hi @muggenhor, @paoloambrosio, @konserw, this issue has come up again. Would you consider merging this PR?
I'm not maintaining this repo anymore. From a quick scan it looks good to me. I'll leave it to the new maintainer @jermus67 to review and merge.
Hi @src-ableton,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:
On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber
@aslakhellesoy Thanks for the invitiation to the organization! I was unable to accept, however, having been on vacation the last three weeks. Could you please re-send the invite?
@src-ableton done!
Summary
This branch adds support for handling characters outside of the Unicode block 'Basic Latin' by updating
json-spirit
to the latest version and modifyingcucumber-cpp
to properly handle this change.Motivation and Context
This change adds support for passing raw UTF-8 strings from
cucumber-cpp
tocucumber-ruby
which is necessary when writing tests which use non-'Basic Latin' characters to validate application behavior.This relates to and resolves #40.
How Has This Been Tested?
This branch adds three new tests (5fff48f).
These tests were run following
cucumber-cpp
's own instructions for building and testing.WireProtocolTest
in addition to modifying theWireResponseEncoder::encode
. The modified test, demonstrating correct behavior, passes.Types of changes
Checklist: