Fix compilation with Boost 1.70.0

homespring commented 5 years ago

Summary

I have fixed a build error when using Boost 1.70.0.

Details

I have added one missing parameter in log_build_info() method overload.

Motivation and Context

I wanted to use Boost library version 1.70.0 but the compilation failed.

How Has This Been Tested?

I ran your tests and all of them passed (110/110).

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[x ] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
[ x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
[ ] I've added tests for my code.
[ ] I have verified whether my change requires changes to the documentation
[ x] My change either requires no documentation change or I've updated the documentation accordingly.
[ ] My branch has been rebased to master, keeping only relevant commits.

coveralls commented 5 years ago

Coverage remained the same at 62.47% when pulling 3140b313c41d62ce9dbfecd59ce488757732fd8f on homespring:fix-boost-1.70.0-build into dd424c1a900cb41c5db9d481714eb3471ce195e3 on cucumber:main.

jermus67 commented 3 years ago

This PR will be merged, despite travis and appvayor complainging. Github actions has been advised from within the cucumber committers community as the go-to alternative, so I see no point anymore in putting effort in making the build clean according to the current build systems. In the current form the main branch does not compile out of the box with "modern" systems, and merging this one will be helpful to that end.

Thanks @homespring for the contribution, and @mattwynne for trying to make it pass the CI checks.

aslakhellesoy commented 3 years ago

Hi @homespring,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

cucumber / cucumber-cpp