Bugfixes

[LukasWoodtli]

Summary

This is a combination of #228 and #227

Details

This combined PR is used to check that both fixes together let the CI builds pass.

Motivation and Context

Because there are two not

How Has This Been Tested?

See the individual PR's.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue).
• [ ] New feature (non-breaking change which adds functionality).
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• [x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
• [x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
• [ ] I've added tests for my code.
• [x] I have verified whether my change requires changes to the documentation
• [x] My change either requires no documentation change or I've updated the documentation accordingly.
• [x] My branch has been rebased to master, keeping only relevant commits.

[coveralls]

Coverage remained the same at 62.47% when pulling adfebcb4767561cd7db02d992267222e4aee9d25 on LukasWoodtli:Bugfixes into dd424c1a900cb41c5db9d481714eb3471ce195e3 on cucumber:master.

[LukasWoodtli]

@muggenhor, @paoloambrosio, @konserw Could anyone of you review this. I'm asking you because you are the main contributors...

[jermus67]

Hello @LukasWoodtli ,

Maintenance of cucumber-cpp is in the process of being picked up again. The file BoostDriver.cpp has been a popular one to be fixed :). Unfortunately this means that this PR cannot be merged right now. I don't know if you are still active, but if you are, could you update this PR by resolving the conflict for the BoostDriver.cpp? When that is done it can be merged, since the other change is a setting in the QT domain.

There is talk of setting up plugin support for test drivers, so that adding support for frameworks like QT and Google Test, and hence configuring how they are compiled, do not need to be part of cucumber-cpp anymore, but since such a solution is only in the "that might be a good idea" phase any bugfix, also in the test driver support is welcome.

Kind regards, Jeroen Kouwer

[jermus67]

Hallo @LukasWoodtli

I've taken a leap of faith an merged the other PR (#228, about the QSignalMapper), which saves you the trouble of updating an ancient PR.

Thanks for having provided the fixes.

Kind regards, Jeroen Kouwer

[LukasWoodtli]

Hello @jermus67 Cool that cucumber-cpp is back on stage! Unfortunately I am currently not able to participate. Keep going!