cucumber / cucumber-cpp

Support for writing Cucumber step definitions in C++
MIT License
306 stars 131 forks source link

Enable compiling with clang's -Wsuggest-override #244

Closed toh-ableton closed 2 years ago

toh-ableton commented 3 years ago

Summary

When compiling step definitions with clang's -Wsuggest-override, clang warns about every step definition because the expanded body() from the macro overrides a virtual function, but isn't marked override.

Checklist:

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 62.47% when pulling 77aed48dda831ce3ef0846ea7742780e08403a57 on AbletonAppDev:add-cuke-override into dd424c1a900cb41c5db9d481714eb3471ce195e3 on cucumber:master.

aslakhellesoy commented 2 years ago

Hi @toh-ableton,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

toh-ableton commented 2 years ago

@aslakhellesoy I was out-of-office the last two weeks, and couldn't accept the invite for this reason. Could you send it again? Thank you!