Add support for latest GoogleTest and Boost

canmor commented 2 years ago

Add support for latest GoogleTest and Boost

Details

Latest boost (since 1.76.0) required C++11 to work with
Latest GoogleTest (newer than 1.8.x) required C++11
Newer GoogleTest change its binary library build output path

Motivation and Context

How Has This Been Tested?

test with GoogleTest v1.8, v1.8.1, v1.10, v1.11, on macOS, with Clang v12 test with Boost v1.76.0

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] New feature (non-breaking change which adds functionality).

Checklist:

[x] It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
[x] I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
[ ] I've added tests for my code.
[x] I have verified whether my change requires changes to the documentation
[x] My change either requires no documentation change or I've updated the documentation accordingly.
[x] My branch has been rebased to master, keeping only relevant commits.

jermus67 commented 2 years ago

Oh! wait! How did I miss this?! It's already hanging around for more than a couple of months... This is nice :) I'll test this feature branch, as the checks do not work as expected right now. We still need someone (me? but I'm quite busy, so busy that I didn't look at this place for some time) proficient in setting up CI to make that work again.

jermus67 commented 2 years ago

Tested with Boost (1.71.1, as that is the newest version for my system) and with (downloaded) google test (1.11.0). Both build and work as expected in my environment. ... It builds on the machine the PR has been made on, it builds when downloaded in a relatively recent other environment (mine). I think that given the current state of the CI this is the best we can get regarding checks for now ...

Thanks for sorting out how to get the newer GoogleTest and Boost into the CMake configuration (while retaining backwards compatibility so that cucumber-cpp still builds with older versions of those libraries). Nice bit of work!

aslakhellesoy commented 2 years ago

Hi @canmor,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber

cucumber / cucumber-cpp