cucumber / cucumber-cpp

Support for writing Cucumber step definitions in C++
MIT License
308 stars 131 forks source link

add Qt on CI system #251

Closed ursfassler closed 2 years ago

ursfassler commented 2 years ago

Summary

Execute Qt tests on CI.

Details

Adding Qt to the CI system.

Motivation and Context

The Qt tests are not run on the CI system because they are not found. We may not know about a broken state for a long time.

This is a base to add another fix for the latest Qt versions: https://github.com/ursfassler/cucumber-cpp/tree/fix-build-with-qt5.15.2.

How Has This Been Tested?

With the github action.

Types of changes

Checklist:

mpkorstanje commented 2 years ago

Cheers! Would you mind looking at the appveyor tests too? If they're not duplicates of the current set of tests in GitHub?

ursfassler commented 2 years ago

The appveyor tests seem to use Qt, but only run on Windows. All of them fail during gem install bundle. Is this what you asked for? Should we discuss the whole appveyor topic in a bug report?

mpkorstanje commented 2 years ago

That seems reasonable. Though I wouldn't know what to fix about it and wouldn't be able to contribute much. I'm mostly merging everything that looks reasonable to keep momentum going.