cucumber / cucumber-cpp

Support for writing Cucumber step definitions in C++
MIT License
304 stars 131 forks source link

Using C++ standard library where possible instead of boost #264

Closed ursfassler closed 8 months ago

ursfassler commented 9 months ago

Summary

Using C++ standard library where possible instead of boost.

Details

Many boost functionality moved into the C++ standard library over the years. This PR uses the functionality form the standard library instead of boost.

The minimal required C++ standard is C++17.

Motivation and Context

This is a modernization of the code base.

How Has This Been Tested?

No functional changes were made. All tests run in the CI.

Types of changes

Checklist:

luke-hill commented 8 months ago

This should probably live as a new breaking change for whenever the cpp library is released

ursfassler commented 8 months ago

@luke-hill I don't exactly understand what you mean. Do you think we should wait with the changes until a release is done, consider this changes as breaking changes in a new library version or something else?

mattwynne commented 8 months ago

@ursfassler I don't have the knowledge of this codebase to be able to do a decent review of your commits, but given that we don't have anyone else to review this code and you've expressed and interest in helping out as a maintainer I'm going to assume you know what you're doing and merge this. πŸš€

In general, I am trying to encourage everyone with commit rights (which you already have πŸ‘πŸ») to follow the Ship / Show / Ask protocol. Feel free to ask for feedback if you want it, but don't get blocked if you don't or can't get that feedback.