Closed cwellm closed 5 months ago
@cwellm as the "Windows build" is passing but the "run all / build-windows" is not, I would propose to reduce this PR to the "Windows build". I'd say this is enough address https://github.com/cucumber/cucumber-cpp/issues/286 as it shows that it builds on Windows.
@ursfassler Yes, this is now superfluous.
@cwellm well done, that looks good!
One minor thing and then we are ready to merge: the git history has some changes to files that are reverted in later commits (e.g. to the file .github/workflows/run-all.yml, also the windows related files). I'd like to have only relevant changes to the files. This helps to understand the changes in case somebody searches through the history to find an error or so.
You can force push to this branch when you have rewritten the history. Alternatively, I can just "Squash and merge" your changes, but some commits are worth to keep separate (i.e. "Remove unnecessary if condition", maybe " Update README ", for sure "Add concurrency to avoid duplicate flows".
@ursfassler Thanks! :) I rearranged commits.
Hi @cwellm,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:
On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber
Resolves #286
Summary
A CI Workflow was added for Windows.
Details
The CI workflow is bare, i.e. builds only the Cucumber-Cpp core without any test drivers, tests, or examples. To distinguish it better from the Linux build, files have been renamed.
Motivation and Context
We want to be confident that the software works on Windows.
How Has This Been Tested?
CI for Windows
Types of changes
Checklist: