Open kreuzberger opened 4 months ago
Due to the checks: Could you provide a clang-format file (.clang-format) or what should be used for clang-format as default style? Assume clang-format without any further options?
Due to the checks: Could you provide a clang-format file (.clang-format) or what should be used for clang-format as default style? Assume clang-format without any further options?
The format file is checked in: https://github.com/cucumber/cucumber-cpp/blob/main/.clang-format Clang-format may produce slightly different out depending on the version. It usually is no problem.
TLDR: Windows Tests integration, would only merge after some clarifications
On Windows the QtTestDriver failes sometimes. Reason is that in one test the Text Error messages are compared. Due to the nature of the default QtTest output the diff test fails cause the Test execution time differs. This could also occur on linux, but seems not so often there (currently im running windows in VM)
+ Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 2ms
+ ********* Finished testing of cucumber::internal::QtTestObject *********
- Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 1ms
- ********* Finished testing of cucumber::internal::QtTestObject *********
Dont know how to fix.
For the QtTests to work which are not part of ctest the Qt Runtime Path (bin on Windows) must be in PATH. Do currently not know HOW to get this in the CI. Workarounded by having it in the PATH env of the caller. This could be fixed running these Tests in CMake with the runtime Path determined like for the other ctests and let the test code (starting and waiting for the processes) be run with os dependent scripts.
Hi! Would it be possible to let the checks run on commit, so i can see open issues and fix them?
On Windows the QtTestDriver failes sometimes. Reason is that in one test the Text Error messages are compared. Due to the nature of the default QtTest output the diff test fails cause the Test execution time differs.
:astonished: That would be a bad tests, timings shouldn't be compared in the tests. What test is it?
Fixed run-linux.sh issue to use Qt6 and disable Qt5 if both are found
Idea is that only the Qt version you specified is searched for.
On Windows the QtTestDriver failes sometimes. Reason is that in one test the Text Error messages are compared. Due to the nature of the default QtTest output the diff test fails cause the Test execution time differs.
😲 That would be a bad tests, timings shouldn't be compared in the tests. What test is it?
QtTestDriverTest, see open issues from above
@kreuzberger please see my PR #296 to fix the flaky test.
I also investigated if it is possible to capture the test log without needing the file. Unfortunately it seems not to be possible (without too much hacking). Meaning that this PR is quite relevant.
@kreuzberger please see my PR #296 to fix the flaky test.
I also investigated if it is possible to capture the test log without needing the file. Unfortunately it seems not to be possible (without too much hacking). Meaning that this PR is quite relevant.
Commented your PR #296.
@kreuzberger unfortunetaly the Windows build has a problem with gtest.
@cwellm did you also had this problem? Could you also help out with reviewing the windows code?
Summary
Fix #292
Details
Different QtTestDriver Implemenation to ensure no resource lock on windows. Issue with undefined output format for qExec, add explicitly ".txt" extension
Motivation and Context
Fix #292
How Has This Been Tested?
Running internal tests with/without changes on ubuntu 22.04 and win10 vs2019
Types of changes
Checklist: