cucumber / cucumber-cpp

Support for writing Cucumber step definitions in C++
MIT License
304 stars 131 forks source link

fix flaky QtTestDriver test #296

Closed ursfassler closed 3 months ago

ursfassler commented 3 months ago

Summary

The test output contained timing information, leading to a flaky test. Fixed by using the TAP output, that doesn't contain timing information.

Details

See https://doc.qt.io/qt-6/qtest-overview.html#logging-options for more information.

Motivation and Context

Solves the issue from this PR: https://github.com/cucumber/cucumber-cpp/pull/293#issuecomment-2049850379

How Has This Been Tested?

The fix itself is only manually verified. The code has automated tests, hence pretty sure to not have added a regression.

Note: the log output changed, but it should only affect developers reading the log.

Types of changes

Checklist:

ursfassler commented 3 months ago

@kreuzberger please have a look. Would be happy to get feedback if this fixes the flaky tests you encountered.

kreuzberger commented 3 months ago

@kreuzberger please have a look. Would be happy to get feedback if this fixes the flaky tests you encountered.

as the tap format does not contain timing informations, yes this would fix it. :+1: