Closed ursfassler closed 1 month ago
@kreuzberger I took the production code changes from your PR #293 and did a small cleanup. The goal is to have this changes merged; we will see what we do about the windows tests later.
I would appreciate it if you test this changes on windows. If everything is ok, I'll squash and merge this PR.
@kreuzberger I took the production code changes from your PR #293 and did a small cleanup. The goal is to have this changes merged; we will see what we do about the windows tests later.
I would appreciate it if you test this changes on windows. If everything is ok, I'll squash and merge this PR.
I have build and run the tests for config release for this branch. TLDR: The tests were successfull (exluded boost tests)
The first test run didnt work cause the test environment is NOT properly set for the QtTests (see the other changes in my PRS). AFTER adding Qt binary dir to PATH environment variable the tests were successfull.
Summary
This is the code part of PR #293. As suggested there, the Windows test for CI will be handled separately.
Details
Fixes #292.
Motivation and Context
See #293.
How Has This Been Tested?
Types of changes
Checklist: