cucumber / cucumber-eclipse

Eclipse plugin for Cucumber
MIT License
190 stars 147 forks source link

Fix the build #470

Closed mattwynne closed 1 year ago

mattwynne commented 1 year ago

🤔 What's the problem you've observed?

Checks on two new PRs are failing for reasons that I think are unrelated to the change in the PR.

The error looks like this:

Error: [ERROR] 1 error: org/eclipse/tycho/p2maven/repository/P2RepositoryConnectorFactory has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0
Error:  -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) Error in custom provider, java.lang.TypeNotPresentException: Type org.eclipse.tycho.p2maven.repository.P2RepositoryConnectorFactory not present
  at ClassRealm[plugin>org.eclipse.tycho:tycho-p2-director-plugin:3.0.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@277050dc] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
  while locating org.eclipse.aether.spi.connector.RepositoryConnectorFactory annotated with @com.google.inject.name.Named(value="p2")

✨ Do you have a proposal for making it better?

Investigate the cause and fix it!

📚 Any additional context?

https://github.com/cucumber/cucumber-eclipse/pull/468 https://github.com/cucumber/cucumber-eclipse/pull/469


This text was originally generated from a template, then edited by hand. You can modify the template here.

mpkorstanje commented 1 year ago

@mattwynne the first line in the error is a bit long, but it says we need to upgrade the Java version used in CI to 17.

mattwynne commented 1 year ago

Thanks @mpkorstanje, let's see if that works.

mattwynne commented 1 year ago

OK, I've updated to Java 17 but we have a new error:

 Error:  Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:3.0.0:materialize-products (materialize-products) on project cucumber-eclipse: Execution materialize-products of goal org.eclipse.tycho:tycho-p2-director-plugin:3.0.0:materialize-products failed: A required class was missing while executing org.eclipse.tycho:tycho-p2-director-plugin:3.0.0:materialize-products: org/eclipse/tycho/TargetEnvironment

Any suggestions?

laeubi commented 1 year ago

Sorry I missed this issue but it is now fixed with: