[Java] Improve cucumber expression creation performance

jkronegg commented 1 year ago

🤔 What's changed?

Improved CucumberExpression.escapeRegex(String) performance as proposed in https://github.com/cucumber/cucumber-expressions/issues/200. Calls to escapeRegex are about 7 times faster and the overall performance improvement on CucumberExpression new instance is about 7%.

⚡️ What's your motivation?

Fixes #200

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Unit tests have been executed on the previous implementation and proposed implementation to prevent regressions.

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[ ] I've changed the behaviour of the code
- [x] I have added/updated tests to cover my changes.
[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[x] Users should know about my change
- [x] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

jkronegg commented 1 year ago

Hi @mpkorstanje, is anything missing in the PR ? Should I provide more information about the algorithm ?

mpkorstanje commented 1 year ago

No I'm just backlogged for a bit.

mpkorstanje commented 1 year ago

@jkronegg would you be interested in helping out with https://github.com/cucumber/cucumber-jvm/pull/2542. It will eventually enable us to discover all step definitions once, and because of that build all cucumber expressions once (per language) which should significantly improve performance. Though I can imagine that a larger contribution with a longer commitment isn't quite what you are looking for, so if you'd decline that is perfectly understandable.

jkronegg commented 1 year ago

@jkronegg would you be interested in helping out with cucumber/cucumber-jvm#2542. It will eventually enable us to discover all step definitions once, and because of that build all cucumber expressions once (per language) which should significantly improve performance. Though I can imagine that a larger contribution with a longer commitment isn't quite what you are looking for, so if you'd decline that is perfectly understandable.

@mpkorstanje sorry for the long response delay. My employer (https://www.mobiliere.ch/) allows me to work up to 10% of my labor time for the Cucumber framework. I still need to manage the details, but I will be happy to help the Cucumber community.

mpkorstanje commented 1 year ago

Cheers. I'll see if I can write something up to help you get started. I'm unfortunately a bit short on time at the moment.

cucumber / cucumber-expressions