Closed brasmusson closed 10 months ago
blaisep
commented
10 months ago This looks totally fine to me, from a python packaging perspective. I suppose I would be tempted to merge this, except that I'm not super familiar with this project. @mpkorstanje , would it help you if I took care of simple fixes like this?
luke-hill
commented
10 months ago @blaisep we don't have a dedicated person for python to my knowledge. I know Bjorn does a fair bit in many languages. And we have 3 dedicated people for ruby/js/jvm.
We have things like rollbacks and checkpoints for this very reason.
luke-hill
commented
10 months ago @brasmusson I gave the action another kick to see if it would publish python: https://github.com/cucumber/cucumber-expressions/actions/runs/6432369369
🤔 What's changed?
The version of poetry is changed from 1.1.13 to 1.6.1
⚡️ What's your motivation?
To try and fix the release error: https://github.com/cucumber/cucumber-expressions/actions/runs/6432369369/job/17467078344
The root cause is that requests_toolbelt < v1.0 and urllib3 >= 2.0 is used together. These packages are not dependencies of cucumber-expressions, so it must be poetry which uses them and define their versions.
These comments indicate that an updated to a later version of poetry should fix the problem: https://github.com/psf/requests/issues/6441#issuecomment-1633151880
🏷️ What kind of change is this?
x :bug: Bug fix (non-breaking change which fixes a defect)
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.