Refactor stopwatch implementation to do the timing ourselves using our protected performance.now, meaning we can remove the dependency on the unmaintained durations library
Remove the "predictable" implementation of the stopwatch - we used to use it for CCK testing but now don't, so it was only used in one unit test, which here is refactored to tick the clock with sinon in the same way as other tests
Remove beginTiming and endTiming functions and replace with usage of our stopwatch since they were doing the same job
β‘οΈ What's your motivation?
Fixes #2095.
π·οΈ What kind of change is this?
:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
Coverage: 98.563%. Remained the same when pulling 05e4324f425c0b88d50b7b36ab5ffd0835a06746 on feat/durations-again into 71227fe3a8a427f6a3aa32bf3837908571acfd67 on main.
π€ What's changed?
performance.now
, meaning we can remove the dependency on the unmaintaineddurations
librarysinon
in the same way as other testsbeginTiming
andendTiming
functions and replace with usage of our stopwatch since they were doing the same jobβ‘οΈ What's your motivation?
Fixes #2095.
π·οΈ What kind of change is this?
π Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.