Closed davidjgoss closed 1 year ago
From a process point of view I have only one remark:
except maybe SummaryFormatter which is the one people would reasonably extend when building their own.
If this class is open for extension it should be documented as such. And be tested against the specific use cases it aims to support.
Otherwise it will be hard to evolve the code in the future.
🤔 What's changed?
defineStep
- at the time the direction seemed to be to eventually make strict keywords the only behaviour. However there is not a consensus across platforms for doing that, so on that basis it should only be an option. ThePickleStep
model has an 'Unknown' value so we can use that fordefineStep
and just throw if you try to use it with strict keywords. Finally, a user raised a separate concern in defense ofdefineStep
from a linguistics perspective. So overall I think there's no longer a case to remove this.Deprecate the export ofJsonFormatter
class - currently most of the built-in formatter classes are exported like this but I think they should mostly be considered implementation details. When we tackle https://github.com/cucumber/cucumber-js/issues/2239 we'll rewrite this formatter, probably in the new "plugin"-style format we've discussed, so we should get this off the entry point as soon as we can.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.