search

cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.04k stars 1.09k forks source link

run prettier directly #2246

Closed charlierudolph closed 1 year ago

charlierudolph commented 1 year ago

When I originally setup prettier, we ran it as part of eslint, however prettier does not recommend this: https://prettier.io/docs/en/integrating-with-linters.html

Not sure if I missed that guidance originally or didn't look for it.

Anyway, by running it standalone, we can have it standardize formatting in more things. Suggest reviewing this by commit and first commit is my manual changes and then a couple of rounds of running npm run lint-format-autofix (not sure exactly why it took 2 rounds).

coveralls commented 1 year ago

Coverage Status

Coverage: 98.561%. Remained the same when pulling 78aabf45df25214818c4d9e159ac090ff4c78298 on cr-prettier into bf8f6816c1015090a323e38a5052fd6ac6711b51 on main.