cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.04k stars 1.09k forks source link

Base64 encode string literals in JsonFormatter #2261

Closed badeball closed 11 months ago

badeball commented 1 year ago

🤔 What's changed?

This fixes #2260.

This ensures that all embeddings in JSON reports are base64-encoded. This is also how cucumber-json-formatter interprets IDENTITY strings.

⚡️ What's your motivation?

In the JSON output, it's currently impossible to differentiate between strings that were attached as literals vs. those that were base64-encoded to begin with.

🏷️ What kind of change is this?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 1 year ago

Coverage Status

coverage: 98.474%. remained the same when pulling ee9a1b85d983ae8e8481ad4687a48a32f8398543 on base64-encode-literals into 188d64445a27fd7bf546bf3b0a6c0163667b96ca on main.