Demo code needs to await the init to actually work.

cucumber / cucumber-js

Cucumber for JavaScript

https://cucumber.io

MIT License

5.04k stars 1.09k forks source link

Demo code needs to await the init to actually work. #2279

Closed michael-lloyd-morris closed 1 year ago

michael-lloyd-morris commented 1 year ago

🤔 What's changed?

If someone copy-pasted the Selenium example I added in a previous pull request it wouldn't actually work because of a missing await call. While demos don't need to be working code it helps if they are, so rectifying.

🏷️ What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct

coveralls commented 1 year ago

Coverage: 98.489%. Remained the same when pulling be22c84b7fd68942003b2ba298e011496e62e24a on michael-lloyd-morris:needAwait into 951114c538ee0ddffa00c25c0865343c07ea956f on cucumber:main.

michael-lloyd-morris commented 1 year ago

Am I clear to merge?

davidjgoss commented 1 year ago

Am I clear to merge?

Sure.