cucumber / cucumber-js

Cucumber for JavaScript
https://cucumber.io
MIT License
5.05k stars 1.09k forks source link

Add option to pass in custom test suite name for Junit formatter #2286

Closed astocker-scottlogic closed 1 year ago

astocker-scottlogic commented 1 year ago

πŸ€” What's changed?

Added functionality which allows users to pass in custom test suite names for the Junit formatter

⚑️ What's your motivation?

Fixes #2265

🏷️ What kind of change is this?

♻️ Anything particular you want feedback on?

I haven't added anything to the docs because I wasn't sure if there was a suitable place, but I am happy to write some documentation if it is needed :-). I added two unit tests, I tried to stick to the current format being used but I'm not entirely sure it's correct. Finally there is a test failing under the 16x windows build. However it seems this test has failed in other PRs so I'm not sure it's related to the changes I've added.

πŸ“‹ Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

coveralls commented 1 year ago

Coverage Status

Coverage: 98.492% (+0.001%) from 98.49% when pulling cea9f81fa50a4198f43f54dfca73e73abc12a20d on astocker-scottlogic:astocker-2265-custom-formatting-option-junit into 63f30338e6b8dbe0b03ddd2776079a8ef44d47e2 on cucumber:main.

aslakhellesoy commented 1 year ago

Hi @astocker-scottlogic,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

On behalf of the Cucumber core team, Aslak HellesΓΈy Creator of Cucumber