Closed furiel closed 1 year ago
Hi @furiel,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:
On behalf of the Cucumber core team, Aslak Hellesøy Creator of Cucumber
Referring to https://github.com/cucumber/cucumber-js/issues/2290
What's changed?
RerunFormatter
used to log failed attempts even if the attempt was retried. For example, it was possible that a testcase might have been fixed with one of the retry attempts, but still was logged due to earlier failing attempt. From now,RerunFormatter
does not log attempts that are retried.extends
RerunFormatter
.What's your motivation?
I am using
retry
to stabilize tests of a distributed system. It was possible (for example right after a deployment), that the first couple of test attempts are failed against a service. I am also usingRerunFormatter
to log the failures. However, asRerunFormatter
logged the failed attempts too, it was difficult to find out what testcases I needed to look at in case of a regression.I attempted to
extend
RerunFormatter
according to my needs, which turned out to be more complex than I anticipated.I created an issue and this patchet about both behavior of the
RerunFormatter
, and the challenges of it's customization.What kind of change is this?
RerunFormatter
'slogFailedTestCases
output is changed.RerunFormatter
to simplifyextends
-ing from it.Anything particular you want feedback on?
This is my first time I am working with typescript/javascript. I appreciate any feedbacks, let it be small or complex. However, I may need a bit more guidance due to my infamiliarity with the language. Do not hesitate to overexplain the change requests. :) I also set
Allow edits by maintainers
if you feel something is easier for you to change, instead of guiding me through.Checklist: